refactor: Remove parallelism configs from QueryKitSpec.#19280
Open
gianm wants to merge 2 commits intoapache:masterfrom
Open
refactor: Remove parallelism configs from QueryKitSpec.#19280gianm wants to merge 2 commits intoapache:masterfrom
gianm wants to merge 2 commits intoapache:masterfrom
Conversation
This patch reduces QueryKitSpec to simply a QueryKit plus a desired query ID. All parallelism configs are removed. This is useful because QueryKitSpec is not used at all in pre-planned decoupled planning. Therefore, this change helps better align plans created in decoupled mode from plans created with QueryKit. The parameters have been migrated to other locations: - maxLeafWorkerCount is moved to WorkerManager#maxWorkerCount. - maxNonLeafWorkerCount is moved to ControllerContext. - targetPartitionsPerWorker is moved to ControllerContext. Planners can signify that they want their partition counts set to "maxWorkerCount * targetPartitionsPerWorker" by using the new "adjustable" parameter on various ShuffleSpecs.
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch reduces
QueryKitSpecto simply aQueryKitplus a desired query ID. All parallelism configs are removed. This is useful becauseQueryKitSpecis not used at all in pre-planned decoupled planning. Therefore, this change helps better align plans created in decoupled mode from plans created withQueryKit.The parameters have been migrated to other locations:
maxLeafWorkerCountis moved toWorkerManager#maxWorkerCount.maxNonLeafWorkerCountis moved toControllerContext.targetPartitionsPerWorkeris moved toControllerContext. Planners can signify that they want their partition counts set tomaxWorkerCount * targetPartitionsPerWorkerby using the newadjustableparameter on variousShuffleSpec.